git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] gitk: replace commented tab with space

From
Denton Liu <liu.denton@gmail.com>
Date
Sep 11, 2020, 04:36 UTC
Message-ID
<85d669828bf9455ac101f8177a7f46a94d30a114.1599798976.git.liu.denton@gmail.com>
In-Reply-To
<cover.1599798976.git.liu.denton@gmail.com>

In the previous commit, the tab indents were mechanically replaced with spaces. However, one tab, in particular, was missed. This tab was not considered an indentation because it's hidden behind a comment. Manually replace this tab with spaces too.

The only tabs that remain in this file are in the "Gitk key bindings" table where they are used for visual alignment in a user-facing table so leave those alone.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 gitk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitk b/gitk
index 1dae9861ac..0380cd8976 100755
--- a/gitk
+++ b/gitk
@@ -4451,7 +4451,7 @@ proc addviewmenu {n} {
     .bar.view add radiobutton -label $viewname($n) \
         -command [list showview $n] -variable selectedview -value $n
     #$viewhlmenu add radiobutton -label $viewname($n) \
-    #	-command [list addvhighlight $n] -variable selectedhlview
+    #    -command [list addvhighlight $n] -variable selectedhlview
 }
 
 proc showview {n} {
-- 
2.28.0.618.gf4bc123cb7
Previous: Denton LiuNext: Denton Liu
Message 7 of 9 in “gitk: fix mix of tabs and spaces in indentation”
  1. 0/2 gitk: fix mix of tabs and spaces in indentationDenton Liu, Sep 10, 2020
  2. 2/2 gitk: manually fix whitespace errorsDenton Liu, Sep 10, 2020
  3. 1/2 gitk: replace spaces with tabsDenton Liu, Sep 10, 2020
  4. Denton LiuSep 10, 2020
  5. Paul MackerrasSep 10, 2020
  6. 0/2 gitk: fix mix of tabs and spaces in indentationDenton Liu, Sep 11, 2020
  7. 2/2 gitk: replace commented tab with spaceDenton Liu, Sep 11, 2020
  8. 1/2 gitk: replace tabs with spacesDenton Liu, Sep 11, 2020
  9. Paul MackerrasOct 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.