git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation

From
Denton Liu <liu.denton@gmail.com>
Date
Sep 10, 2020, 08:36 UTC
Message-ID
<20200910083615.GA1407716@generichostname>
In-Reply-To
<cover.1599726439.git.liu.denton@gmail.com>
On Thu, Sep 10, 2020 at 01:27:40AM -0700, Denton Liu wrote:
> Denton Liu (2):
>   gitk: replace spaces with tabs

Unfortunately, the patch is too big to be sent by email. It can be retrieved from https://github.com/Denton-L/git.git submitted/gitk-whitespace~.

If you don't want to pull it, the commit without the body is included below. It can be fully reproduced by running the vim commands listed on the gitk file.

-- >8 --
From: Denton Liu <liu.denton@gmail.com>
Date: Wed, 9 Sep 2020 12:10:51 -0700
Subject: [PATCH 1/2] gitk: replace spaces with tabs
To: Git Mailing List <git@vger.kernel.org>,
    Paul Mackerras <paulus@ozlabs.org>

The source code is a mix of tabs and spaces. The indentation style currently is four spaces per indent level but uses tabs every other level (at eight spaces). Fix this inconsistent spacing and tabbing by just using a tab-indent for everything.

This was done mechanically using the following vim commands:
	:set tabstop=8
	:set expandtab
	:retab
	:set tabstop=4
	:set noexpandtab
	:retab!
	:set tabstop=8

A future commit will manually clean up the code style errors introduced by this patch.

This patch should be empty with `--ignore-all-space`.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 gitk | 20408 ++++++++++++++++++++++++++++-----------------------------
 1 file changed, 10204 insertions(+), 10204 deletions(-)
Previous: Denton LiuNext: Paul Mackerras
Message 4 of 9 in “gitk: fix mix of tabs and spaces in indentation”
  1. 0/2 gitk: fix mix of tabs and spaces in indentationDenton Liu, Sep 10, 2020
  2. 2/2 gitk: manually fix whitespace errorsDenton Liu, Sep 10, 2020
  3. 1/2 gitk: replace spaces with tabsDenton Liu, Sep 10, 2020
  4. Denton LiuSep 10, 2020
  5. Paul MackerrasSep 10, 2020
  6. 0/2 gitk: fix mix of tabs and spaces in indentationDenton Liu, Sep 11, 2020
  7. 2/2 gitk: replace commented tab with spaceDenton Liu, Sep 11, 2020
  8. 1/2 gitk: replace tabs with spacesDenton Liu, Sep 11, 2020
  9. Paul MackerrasOct 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.