git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-filter-branch: document --original option

From
David Kastrup <dak@gnu.org>
Date
Aug 30, 2007, 22:00 UTC
Message-ID
<85d4x4d6oi.fsf@lola.goethe.zz>
In-Reply-To
<7vy7fs7kmc.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 33 quoted lines
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> +--original <namespace>::
>> +	Use this option to set the namespace where the original commits
>> +	will be stored. The default value is 'refs/original'.
>> +
>
> The default seems to be "refs/original/".
>
> Even worse.
>
> I think if you say --force --original refs/head (notice the lack
> of "s" nor slash at the end), the code will get you in a *lot*
> of trouble.
>
> Dscho, don't we want to do something like this?
>
> ---
>  git-filter-branch.sh |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-filter-branch.sh b/git-filter-branch.sh
> index 0190060..a7f50a6 100755
> --- a/git-filter-branch.sh
> +++ b/git-filter-branch.sh
> @@ -134,6 +134,7 @@ do
>  		filter_subdir="$OPTARG"
>  		;;
>  	--original)
> +		case "$OPTARG" in */) ;; *) OPTARG="$OPTARG/" ;; esac
>  		orig_namespace="$OPTARG"
>  		;;
>  	*)
orig_namespace="${OPTARG%/}/"

Sure, it does not win the "portable to Version 7" price, but our scripts don't do that, anyway.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 12 in “git-filter-branch: more detailed USAGE”
  1. git-filter-branch: more detailed USAGEGiuseppe Bilotta, Aug 30, 2007
  2. Johannes SixtAug 30, 2007
  3. Giuseppe BilottaAug 30, 2007
  4. git-filter-branch: more detailed USAGEGiuseppe Bilotta, Aug 30, 2007
  5. git-filter-branch: document --original optionGiuseppe Bilotta, Aug 30, 2007
  6. Junio C HamanoAug 30, 2007
  7. David KastrupAug 30, 2007
  8. Junio C HamanoAug 30, 2007
  9. Junio C HamanoAug 30, 2007
  10. David KastrupAug 31, 2007
  11. David KastrupAug 31, 2007
  12. Johannes SchindelinAug 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.