Re: [PATCH] git-filter-branch: document --original option

From: David Kastrup <dak@gnu.org>
Date: Aug 31, 2007, 06:16 UTC
Message-ID: <851wdkcjp4.fsf@lola.goethe.zz>
In-Reply-To: <7v3ay07h0h.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> I agree we do not give the "portable to version 7" prize
>> anymore.  But you made me realize another thing.
>>
>> I think it should make sure orig_namespace has one and only one
>> trailing slash, because otherwise "--original refs/heads//"
>> would lead you to the same disaster.
>
> Perhaps,
>
> 	orig_namespace=$(expr "$OPTARG/" : '\(.*[^/]\)/*$')/
>

See separate proposal which I find still prettier (and which does not fork).

But I really don't think we should bend over backwards: multiple end slashes have explicit manual origin. People deserve what they get then.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum