Re: [PATCH v2 1/1] userdiff: extend Bash pattern to cover more shell function forms

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 22, 2025, 18:15 UTC
Message-ID: <85d3318f-5e5b-48c5-8ba0-27465a2e733f@kdbg.org>
In-Reply-To: <xmqqy0y3jbjk.fsf@gitster.g>

Am 18.02.25 um 20:30 schrieb Junio C Hamano:

Show 10 quoted lines

> Moumita <dhar61595@gmail.com> writes:
>>  	 /* -- */
>> -	 /* Characters not in the default $IFS value */
>> -	 "[^ \t]+"),
> 
> We used to pretty-much use "a run of non-whitespace characters is a
> token".  Now we are a bit more picky.
> 
> Which may or may not be good, but it is hard to tell if it is an
> improvement.

It is only a stand-in, because every built-in userdiff driver must have a word pattern. See the old thread here: https://lore.kernel.org/git/373640ea4d95f3b279b9d460d9a8889b4030b4e9.camel@engmark.name/

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.