From: Johannes Sixt <j6t@kdbg.org>
Date: Sat, 22 Feb 2025 18:15:34 GMT
Subject: Re: [PATCH v2 1/1] userdiff: extend Bash pattern to cover more shell function forms
Message-ID: <85d3318f-5e5b-48c5-8ba0-27465a2e733f@kdbg.org>
In-Reply-To: <xmqqy0y3jbjk.fsf@gitster.g>

Am 18.02.25 um 20:30 schrieb Junio C Hamano:
> Moumita <dhar61595@gmail.com> writes:
>>  	 /* -- */
>> -	 /* Characters not in the default $IFS value */
>> -	 "[^ \t]+"),
> 
> We used to pretty-much use "a run of non-whitespace characters is a
> token".  Now we are a bit more picky.
> 
> Which may or may not be good, but it is hard to tell if it is an
> improvement.

It is only a stand-in, because every built-in userdiff driver must have
a word pattern. See the old thread here:
https://lore.kernel.org/git/373640ea4d95f3b279b9d460d9a8889b4030b4e9.camel@engmark.name/

-- Hannes