Re: [PATCH 1/3] t/README: document GIT_TEST_DEFAULT_HASH
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Aug 14, 2020, 20:41 UTC
- Message-ID
- <8555fa4c-1eba-63da-e59c-edba6a39eac0@gmail.com>
- In-Reply-To
- <CAPig+cQLR1=6W-Y1y1XiWg1pC9FKikpqVsMrDKeK=exLJFDgLg@mail.gmail.com>
On 8/14/2020 4:39 PM, Eric Sunshine wrote:
Show 14 quoted lines
> On Fri, Aug 14, 2020 at 2:07 PM Derrick Stolee via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> diff --git a/t/README b/t/README >> @@ -421,6 +421,9 @@ GIT_TEST_DISALLOW_ABBREVIATED_OPTIONS=<boolean>, when true> +GIT_TEST_DEFAULT_HASH=<sha1|sha256> specifies which hash algorithm to use >> +in the test scripts. > > Nit: The documentation for all the other environment variables has the > form `GIT_VAR=<generic-value-indicator>` rather than placing the > possible literal values within the angle brackets. So, perhaps this > can be written as: > > GIT_TEST_DEFAULT_HASH=<hash-algo> specifies which hash algorithm > to use in the test scripts. Recognized values for <hash-algo> are > "sha1" and "sha256".
Sounds good!
Thanks, -Stolee