Re: 'git fast-export' is crashing on the gcc repo

From: David Kastrup <dak@gnu.org>
Date: Dec 12, 2007, 08:46 UTC
Message-ID: <854peo8fm5.fsf@lola.goethe.zz>
In-Reply-To: <7v3au89utj.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

> Nicolas Pitre <nico@cam.org> writes:
>
>> On Wed, 12 Dec 2007, Alex Riesen wrote:
>>
>>> Nicolas Pitre, Tue, Dec 11, 2007 23:06:42 +0100:
>>> > 
>>> > Well, ignore the above.  It seems that most of stdio doesn't set errno 
>>> > so the above is crap.
>>> > 
>>> 
>>> Well, it had no reason to in this case. It's not an error.
>>> It does not even have to do a syscall.
>>
>> Which is why I later agreed with your patch.
>
> Still, I like your swapping of size and nmemb parameters, regardless
> of the "don't bother calling fwrite(3) if size is zero" fix.

I don't. Far too obscure, looks like an unintentional wart waiting to be corrected.

I think that the explicit test is the way to go here.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum