Re: 'git fast-export' is crashing on the gcc repo
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Dec 12, 2007, 01:38 UTC
- Message-ID
- <20071212013828.GC19857@steel.home>
- In-Reply-To
- <alpine.LFD.0.99999.0712111703380.555@xanadu.home>
Nicolas Pitre, Tue, Dec 11, 2007 23:06:42 +0100:
> > Well, ignore the above. It seems that most of stdio doesn't set errno > so the above is crap. >
Well, it had no reason to in this case. It's not an error. It does not even have to do a syscall.
Show 10 quoted lines
> diff --git a/builtin-fast-export.c b/builtin-fast-export.c
> index 2136aad..c32a124 100755
> --- a/builtin-fast-export.c
> +++ b/builtin-fast-export.c
> @@ -103,7 +103,7 @@ static void handle_object(const unsigned char *sha1)
> mark_object(object);
>
> printf("blob\nmark :%d\ndata %lu\n", last_idnum, size);
> - if (fwrite(buf, size, 1, stdout) != 1)
> + if (fwrite(buf, 1, size, stdout) != size)That's a probable syscall which could be spared