git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] ci(osx): use new location of the `perforce` cask

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 15, 2019, 17:32 UTC
Message-ID
<84830d89eb330f256b3802e0c1b63ff32030ff79.1571160721.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.400.git.1571160721.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

The CI builds are failing for Mac OS X due to a change in the location of the perforce cask. The command outputs the following error:

    + brew install caskroom/cask/perforce
    Error: caskroom/cask was moved. Tap homebrew/cask-cask instead.

Preface the "brew install caskroom/cask/perforce" with the old way of installing perforce, and only try this method if the "brew install perforce" fails.

The existing way to use caskroom was added in 672f51cb (travis-ci: fix Perforce install on macOS, 2017-01-22) and the justification is that the "brew install perforce" can fail due to a hash mis-match. The mismatch is due to the official Perforce distro updating the published binaries without updating the version string. CI servers are typically fresh virtual machines, so that issue should not arise in automated builds.

Even if a build server is re-used and hits the hash mis-match, it will fall back to the "new" mechanism which is currently failing, but may be fixed independently of this change.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
---
 ci/install-dependencies.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 85a9d6b15c..489b5dcf17 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -40,6 +40,7 @@ osx-clang|osx-gcc)
 	test -z "$BREW_INSTALL_PACKAGES" ||
 	brew install $BREW_INSTALL_PACKAGES
 	brew link --force gettext
+	brew cask install perforce ||
 	brew install caskroom/cask/perforce
 	case "$jobname" in
 	osx-gcc)
-- 
gitgitgadget
Previous: Derrick Stolee via GitGitGadgetNext: Johannes Schindelin
Message 2 of 24 in “ci: update caskroom/cask/perforce to new location”
  1. 0/1 ci: update caskroom/cask/perforce to new locationDerrick Stolee via GitGitGadget, Oct 15, 2019
  2. 1/1 ci(osx): use new location of the `perforce` caskJohannes Schindelin via GitGitGadget, Oct 15, 2019
  3. Johannes SchindelinOct 17, 2019
  4. 0/1 ci: update caskroom/cask/perforce to new locationDerrick Stolee via GitGitGadget, Oct 17, 2019
  5. 1/1 ci(osx): use new location of the `perforce` caskJohannes Schindelin via GitGitGadget, Oct 17, 2019
  6. SZEDER GáborOct 18, 2019
  7. Junio C HamanoOct 21, 2019
  8. Johannes SchindelinOct 22, 2019
  9. Junio C HamanoOct 22, 2019
  10. Johannes SchindelinOct 22, 2019
  11. SZEDER GáborOct 23, 2019
  12. 0/1 ci: update caskroom/cask/perforce to new locationDerrick Stolee via GitGitGadget, Oct 23, 2019
  13. 1/1 ci(osx): use new location of the `perforce` caskJohannes Schindelin via GitGitGadget, Oct 23, 2019
  14. Junio C HamanoOct 23, 2019
  15. SZEDER GáborOct 23, 2019
  16. ci: fix GCC install in the Travis CI GCC OSX jobSZEDER Gábor, Oct 24, 2019
  17. SZEDER GáborNov 18, 2019
  18. Johannes SchindelinNov 19, 2019
  19. Junio C HamanoNov 20, 2019
  20. Johannes SchindelinNov 20, 2019
  21. Junio C HamanoNov 20, 2019
  22. SZEDER GáborNov 20, 2019
  23. Junio C HamanoNov 21, 2019
  24. Johannes SchindelinNov 21, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.