Re: [PATCH v3 1/1] ci(osx): use new location of the `perforce` cask
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Oct 23, 2019, 16:35 UTC
- Message-ID
- <20191023163506.GJ4348@szeder.dev>
- In-Reply-To
- <xmqqsgnjhj5b.fsf@gitster-ct.c.googlers.com>
On Wed, Oct 23, 2019 at 07:05:04PM +0900, Junio C Hamano wrote:
Show 32 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > The Azure Pipelines builds are failing for macOS due to a change in the
> > location of the perforce cask. The command outputs the following error:
> >
> > + brew install caskroom/cask/perforce
> > Error: caskroom/cask was moved. Tap homebrew/cask-cask instead.
> > ...
> > In any case, as the error message at the top of this commit message
> > shows, 'brew install caskroom/cask/perforce' has stopped working
> > recently, but 'brew cask install perforce' still does, so let's use
> > that.
>
> It appears that OSX jobs at Travis are getting hit by this issue.
> Here is what our failed build ends with, for example:
>
> +brew install caskroom/cask/perforce
> Error: caskroom/cask was moved. Tap homebrew/cask-cask instead.
>
> cf. https://travis-ci.org/git/git/jobs/601697815
>
> Today's 'pu' has this topic queued, and it seems to help even the
> builds at Travis ('pu' seems to fail the test for totally different
> reason, though):
>
> +brew link gcc@8
> Error: No such keg: /usr/local/Cellar/gcc@8
>
> cf. https://travis-ci.org/git/git/jobs/601697903Yeah, that's a new one, so we don't get too bored. We'll need the patch below as well:
--- >8 ---
Subject: [PATCH] ci: fix GCC install in the GCC OSX job
A few days ago Travis CI updated their existing OSX images, including the Homebrew database in the xcode10.1 OSX image that we use. Since then installing dependencies in the 'osx-gcc' job fails when it tries to link gcc@8:
+ brew link gcc@8 Error: No such keg: /usr/local/Cellar/gcc@8
Apparently 'brew link gcc' works, so let's do that then, and fall back to linking gcc@8 if it doesn't.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> --- ci/install-dependencies.sh | 1 + 1 file changed, 1 insertion(+)
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index ce149ed39c..4e64a19112 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -48,6 +48,7 @@ osx-clang|osx-gcc) brew install caskroom/cask/perforce case "$jobname" in osx-gcc) + brew link gcc || brew link gcc@8 ;; esac
-- 2.24.0.rc0.502.g7008375535