git/list[1] front-page[2] threads[3] people[4] search[5] about
 

FREAD_READS_DIRECTORIES test fails for the wrong reasons

From
JPJonathan Primrose <jprimros@gmail.com>
Date
Apr 6, 2018, 18:06 UTC
Message-ID
<82c91eac-9dc4-834b-4648-3c4ba45af80d@gmail.com>

A while ago, the configure test for FREAD_READS_DIRECTORIES was changed to (attempt to) check for a NULL result from fopen. Unfortunately, the test will always fail - because it won't compile. The code snippet in configure.ac translates to:

return f);

Either there's an extra ) or a missing (. A cast to int wouldn't hurt either.

I'd supply a patch to fix this, but I'm not sure what the results of suddenly fixing the test would be. It seems to work well on my machine, but I don't stress git much here, and it's just one machine.

Next: Jeff King
Message 1 of 4 in “FREAD_READS_DIRECTORIES test fails for the wrong reasons”
  1. Jonathan PrimroseApr 6, 2018
  2. Jeff KingApr 6, 2018
  3. Jonathan PrimroseApr 6, 2018
  4. Jeff KingApr 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.