git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: FREAD_READS_DIRECTORIES test fails for the wrong reasons

From
Jeff King <peff@peff.net>
Date
Apr 6, 2018, 22:07 UTC
Message-ID
<20180406220736.GH7870@sigill.intra.peff.net>
In-Reply-To
<8ed8491f-9410-c509-5ef7-77638aa74038@gmail.com>
On Fri, Apr 06, 2018 at 05:57:15PM -0400, Jonathan Primrose wrote:
Show 12 quoted lines
> > Oops. This is due to my 3adf9fdecf (configure.ac: loosen
> > FREAD_READS_DIRECTORIES test program, 2017-06-14).
> > 
> > Neither I nor the original tester noticed, because we're on Linux, which
> > needs that set.
> 
> I'm also running Linux, but somehow I ended up needing to check
> config.log and saw the error. I don't remember why I had to check.
> (I've been fixing the problem locally for the last few releases,
> figuring someone else would notice. I also remove the 'rm configure'
> from the distclean target in Makefile, just in case I decide to
> rebuild later.)

I think you'll find that most of the developers don't actually use autoconf themselves, so bugs tend to go unnoticed there for a while. (The failure case for setting this flag accidentally is not bad, either; it just incurs an extra fstat).

-Peff
Previous: Jonathan Primrose
Message 4 of 4 in “FREAD_READS_DIRECTORIES test fails for the wrong reasons”
  1. Jonathan PrimroseApr 6, 2018
  2. Jeff KingApr 6, 2018
  3. Jonathan PrimroseApr 6, 2018
  4. Jeff KingApr 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.