Re: [PATCH v2 7/8] merge-ort: skip rename detection entirely if possible

From: Derrick Stolee <stolee@gmail.com>
Date: Mar 9, 2021, 22:51 UTC
Message-ID: <82be59b5-a930-ddca-c694-14f27a9fbae6@gmail.com>
In-Reply-To: <cd931286f24d66efbf6b0f0a1f520b58ac468f88.1615248599.git.gitgitgadget@gmail.com>

On 3/8/2021 7:09 PM, Elijah Newren via GitGitGadget wrote:> +	goto simple_cleanup; /* collect_renames() handles some of cleanup */

Show 7 quoted lines

> +
> +cleanup:
> +	/*
> +	 * Free now unneeded filepairs, which would have been handled
> +	 * in collect_renames() normally but we're about to skip that
> +	 * code...
> +	 */

"but we're about to skip that code"

Haven't you skipped it already, earlier in the above part? This should instead say "but we skipped that code", right?

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.