Re: [PATCH] Re: Gitk --all error when there are more than 797 refs in a repository
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Nov 3, 2009, 10:04 UTC
- Message-ID
- <81b0412b0911030204v46adf54gb9ed65e78ce2b6df@mail.gmail.com>
- In-Reply-To
- <7v1vlzvjtg.fsf@alter.siamese.dyndns.org>
On Tue, Sep 22, 2009 at 02:39, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Pat Thoyts <patthoyts@users.sourceforge.net> writes:
>> if {$revs eq {}} {
>> set revs HEAD
>> + } elseif {$revs eq "--all"} {
>> + return $revs
>> }
>
> That looks like an ugly hack (aka sweeping the issue under the rug).
>And it is a race condition. By the time git log has got --all list of references it may look completely different to what gitk has.