Re: [PATCH] Re: Gitk --all error when there are more than 797 refs in a repository
- From
Paul Mackerras <paulus@samba.org>
- Date
- Nov 3, 2009, 10:41 UTC
- Message-ID
- <19184.2253.656355.506185@cargo.ozlabs.ibm.com>
- In-Reply-To
- <81b0412b0911030204v46adf54gb9ed65e78ce2b6df@mail.gmail.com>
Alex Riesen writes:
Show 13 quoted lines
> On Tue, Sep 22, 2009 at 02:39, Junio C Hamano <gitster@pobox.com> wrote:
> > Pat Thoyts <patthoyts@users.sourceforge.net> writes:
> >> if {$revs eq {}} {
> >> set revs HEAD
> >> + } elseif {$revs eq "--all"} {
> >> + return $revs
> >> }
> >
> > That looks like an ugly hack (aka sweeping the issue under the rug).
> >
>
> And it is a race condition. By the time git log has got --all list of references
> it may look completely different to what gitk has.Yes, exactly. Until git log understands --stdin, I think the only real solution is to disable the view update optimization on windows.
Paul.