Re: git hang with corrupted .pack

From: Alex Riesen <raa.lkml@gmail.com>
Date: Oct 20, 2009, 15:36 UTC
Message-ID: <81b0412b0910200836q3f519ac3l912cc1c4299047f4@mail.gmail.com>
In-Reply-To: <fabb9a1e0910200823h280a875p98c61eb5e5e6018a@mail.gmail.com>

On Tue, Oct 20, 2009 at 17:23, Sverre Rabbelier <srabbelier@gmail.com> wrote:

Show 12 quoted lines

> Heya,
>
> On Tue, Oct 20, 2009 at 10:14, Alex Riesen <raa.lkml@gmail.com> wrote:
>> -       buffer = xmalloc(size + 1);
>> +       buffer = xmalloc(size + 8);
>
>> -       stream.avail_out = size;
>> +       stream.avail_out = size + 8;
>
> That seems wrong at first glance, you go from '+1' to '+8' on the
> first part, and then from '+0' to '+8' in the second part, am I
> missing something obvious?

Yes. The "size" (the variable) is never changed. It is just the output buffer size, not how many data expected or something like that. IOW, I just wanted the buffer to be obviously (to zlib) more than enough.