From: Alex Riesen Date: Tue, 20 Oct 2009 15:36:28 GMT Subject: Re: git hang with corrupted .pack Message-ID: <81b0412b0910200836q3f519ac3l912cc1c4299047f4@mail.gmail.com> In-Reply-To: On Tue, Oct 20, 2009 at 17:23, Sverre Rabbelier wrote: > Heya, > > On Tue, Oct 20, 2009 at 10:14, Alex Riesen wrote: >> -       buffer = xmalloc(size + 1); >> +       buffer = xmalloc(size + 8); > >> -       stream.avail_out = size; >> +       stream.avail_out = size + 8; > > That seems wrong at first glance, you go from '+1' to '+8' on the > first part, and then from '+0' to '+8' in the second part, am I > missing something obvious? Yes. The "size" (the variable) is never changed. It is just the output buffer size, not how many data expected or something like that. IOW, I just wanted the buffer to be obviously (to zlib) more than enough.