Re: [PATCH] Expand the rename(2) workaround in mingw to cover case change in filename

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jun 8, 2009, 22:08 UTC
Message-ID: <81b0412b0906081508v5435c59cm3faf3ac92a56578c@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0906082355350.26154@pacific.mpi-cbg.de>

2009/6/8 Johannes Schindelin <Johannes.Schindelin@gmx.de>:

Show 5 quoted lines

> On Mon, 8 Jun 2009, Alex Riesen wrote:
>> NOT TESTED. Can't. My Windows broke again. Not even compile-tested.
>
> Yes, that is pretty easy to see as you first used pold/pnew and then
> src/dst.

Yep.

Show 8 quoted lines

> I minimally fixed up your patch (it now uses strbuf), and added a
> test-case.
>
> This test-case is actually crucial: it shows that your patch is not
> enough: the culprit is this code in builtin-mv.c:167--168:
>
>                else if (lstat(dst, &st) == 0) {
>                        bad = "destination exists";

Ah, thanks. Missed that completely.