Re: [PATCH] Expand the rename(2) workaround in mingw to cover case change in filename

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jun 9, 2009, 05:54 UTC
Message-ID: <4A2DF92D.1080605@viscovery.net>
In-Reply-To: <81b0412b0906081508v5435c59cm3faf3ac92a56578c@mail.gmail.com>

Alex Riesen schrieb:

Show 18 quoted lines

> 2009/6/8 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
>> On Mon, 8 Jun 2009, Alex Riesen wrote:
>>> NOT TESTED. Can't. My Windows broke again. Not even compile-tested.
>> Yes, that is pretty easy to see as you first used pold/pnew and then
>> src/dst.
> 
> Yep.
> 
>> I minimally fixed up your patch (it now uses strbuf), and added a
>> test-case.
>>
>> This test-case is actually crucial: it shows that your patch is not
>> enough: the culprit is this code in builtin-mv.c:167--168:
>>
>>                else if (lstat(dst, &st) == 0) {
>>                        bad = "destination exists";
> 
> Ah, thanks. Missed that completely.

That's the reason why I think any work-around for this problem is not worth it.

If you want to be cross-platfrom, make up your mind about file names in advance.

-- Hannes