git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: test applying criss-cross rename patch

From
Alex Riesen <raa.lkml@gmail.com>
Date
Apr 20, 2009, 14:11 UTC
Message-ID
<81b0412b0904200711p66ea2500s7cc5894aba71f641@mail.gmail.com>
In-Reply-To
<1239463584-1427-1-git-send-email-michal.kiedrowicz@gmail.com>
2009/4/11 Michał Kiedrowicz <michal.kiedrowicz@gmail.com>:
Show 11 quoted lines
> +test_expect_success 'criss-cross rename' '
> +       mv file1 tmp &&
> +       mv file2 file1 &&
> +       mv tmp file2
> +'
> +
> +test_expect_success 'diff -M -B' '
> +       git diff -M -B > diff &&
> +       git reset --hard
> +
> +'

This cannot work on systems where ctime is not trusted: git diff will produce no data, as there are no changes in metadata (the files are of the same size). Either make the file sizes different or add a "touch file1 file2".

diff --git a/t/t4130-apply-criss-cross-rename.sh
b/t/t4130-apply-criss-cross-rename.sh
index 8623dbe..1ff049a 100755
--- a/t/t4130-apply-criss-cross-rename.sh
+++ b/t/t4130-apply-criss-cross-rename.sh
@@ -14,7 +14,7 @@ create_file() {

 test_expect_success 'setup' '
 	create_file file1 "File1 contents" &&
-	create_file file2 "File2 contents" &&
+	create_file file2 "Contents of File2" &&
 	git add file1 file2 &&
 	git commit -m 1
 '
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “buglet: 'git apply' doesn't handle criss-cross renames”
  1. Linus TorvaldsApr 9, 2009
  2. tests: test applying criss-cross rename patchMichał Kiedrowicz, Apr 11, 2009
  3. Junio C HamanoApr 13, 2009
  4. Junio C HamanoApr 13, 2009
  5. Alex RiesenApr 20, 2009
  6. Junio C HamanoApr 21, 2009
  7. Alex RiesenApr 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.