Re: [PATCH] tests: test applying criss-cross rename patch

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 13, 2009, 19:28 UTC
Message-ID: <7vvdp8e4k2.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vd4bgh560.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 23 quoted lines

> Michał Kiedrowicz <michal.kiedrowicz@gmail.com> writes:
>
>> Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
>> ---
>>  t/t4130-apply-criss-cross-rename.sh |   35 +++++++++++++++++++++++++++++++++++
>>  1 files changed, 35 insertions(+), 0 deletions(-)
>>  create mode 100755 t/t4130-apply-criss-cross-rename.sh
>>
>> diff --git a/t/t4130-apply-criss-cross-rename.sh b/t/t4130-apply-criss-cross-rename.sh
>> new file mode 100755
>> index 0000000..30187ff
>> --- /dev/null
>> +++ b/t/t4130-apply-criss-cross-rename.sh
>> @@ -0,0 +1,35 @@
>> +#!/bin/sh
>> +
>> +test_description='git apply handling criss-cross rename patch.'
>> +. ./test-lib.sh
>> +
>> +create_file() {
>> +	for ((i=0; i<100; i++)); do
>
> Please don't; isn't this a bashism?

I've queued your two patches with minimum fix-up (not covering all the points in my comments) to 'pu'. You may want to take a look and send in improvement to replace them.

Thanks.