git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Windows: Skip fstat/lstat optimization in write_entry()

From
Alex Riesen <raa.lkml@gmail.com>
Date
Apr 20, 2009, 12:58 UTC
Message-ID
<81b0412b0904200558w2d506f18i675d5dfb990005ce@mail.gmail.com>
In-Reply-To
<20090420110302.GB25059@dpotapov.dyndns.org>
2009/4/20 Dmitry Potapov <dpotapov@gmail.com>:
Show 7 quoted lines
> The cygwin version has the same problem. (In fact, it is even worse,
> because we have an optimized version for lstat/stat but not for fstat,
> and they return different values for some fields like i_no). But even
> if we used the only Cygwin functions, we would still face the problem,
> because Windows returns the wrong values for timestamps (and maybe
> even size on FAT?). So I think the following patch should be squashed
> on top.

I just sent a patch with an "optimized" fstat. I see no problems (at least none like these) with that patch. Timestamps match. Windows XP, yes. But since that MSDN article mentions that it is not guaranteed, I guess I just been lucky.

Previous: Hannu KoivistoNext: Dmitry Potapov
Message 5 of 12 in “Windows: Skip fstat/lstat optimization in write_entry()”
  1. 2/2 Windows: Skip fstat/lstat optimization in write_entry()Johannes Sixt, Apr 20, 2009
  2. Johannes SchindelinApr 20, 2009
  3. Dmitry PotapovApr 20, 2009
  4. Hannu KoivistoApr 20, 2009
  5. Alex RiesenApr 20, 2009
  6. Dmitry PotapovApr 20, 2009
  7. Alex RiesenApr 20, 2009
  8. Johannes SixtApr 20, 2009
  9. Alex RiesenApr 20, 2009
  10. Alex RiesenApr 20, 2009
  11. Junio C HamanoApr 20, 2009
  12. Alex RiesenApr 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.