Re: [PATCH 2/2] Windows: Skip fstat/lstat optimization in write_entry()

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Apr 20, 2009, 11:03 UTC
Message-ID: <20090420110302.GB25059@dpotapov.dyndns.org>
In-Reply-To: <49EC2F7C.8070209@viscovery.net>

The cygwin version has the same problem. (In fact, it is even worse, because we have an optimized version for lstat/stat but not for fstat, and they return different values for some fields like i_no). But even if we used the only Cygwin functions, we would still face the problem, because Windows returns the wrong values for timestamps (and maybe even size on FAT?). So I think the following patch should be squashed on top.

-- >8 --
From 1f957680d9b0e0bfeda9bf0e20397b0323b45334 Mon Sep 17 00:00:00 2001
From: Dmitry Potapov <dpotapov@gmail.com>
Date: Mon, 20 Apr 2009 14:54:16 +0400
Subject: [PATCH] cygwin: Skip fstat/lstat optimization in write_entry()

---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 2af0dfb..177dc15 100644
--- a/Makefile
+++ b/Makefile
@@ -809,6 +809,7 @@ ifeq ($(uname_S),HP-UX)
 endif
 ifneq (,$(findstring CYGWIN,$(uname_S)))
 	COMPAT_OBJS += compat/cygwin.o
+	UNRELIABLE_FSTAT = UnfortunatelyYes
 endif
 ifneq (,$(findstring MINGW,$(uname_S)))
 	NO_PREAD = YesPlease

-- 
1.6.1.20.gee856
-- >8 --