Re: git-send-pack SIGSEGV..

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jun 15, 2007, 07:24 UTC
Message-ID: <81b0412b0706150024m6a3c4d0bx866e1b25e770d299@mail.gmail.com>
In-Reply-To: <7vr6od92nj.fsf@assigned-by-dhcp.pobox.com>

On 6/15/07, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> --- a/remote.c
> +++ b/remote.c
> @@ -252,6 +252,8 @@ static struct refspec *parse_ref_spec
>                         ep = gp;
>                 }
>                 rs[i].src = xstrndup(sp, ep - sp);
> +               if (rs[i].pattern && !rs[i].dst)
> +                       rs[i].dst = xstrdup(rs[i].src);

It may be possible to just reuse rs[i].src - there is no deallocation of refspecs anywhere nor are src or dst detached from refspec (which may be bad, but probably is covered in libification effort).