Re: git-send-pack SIGSEGV..
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 15, 2007, 05:50 UTC
- Message-ID
- <7vvedp935y.fsf@assigned-by-dhcp.pobox.com>
- In-Reply-To
- <alpine.LFD.0.98.0706142124380.14121@woody.linux-foundation.org>
Linus Torvalds <torvalds@linux-foundation.org> writes:
> I *suspect* it's due to the refspec pattern matching changes Daniel did, > but again - I haven't actually debugged it any deeper.
I am officially recuperating from an operation I had today, so I cannot really take a deep look at this.
I think what is going wrong is that struct refspec for pattern match that is parsed by parse_ref_spec does not have ->dst component filled for "refs/tags/*" refspec, but match_refs() does not check if pat->dst is NULL, in which case it should reuse pat->src value.
Incidentally I have other remote.c fixes queued in 'next'. I haven't yet checked if I (accidentally) fixed this already.