Re: [PATCH] Fix the remote note the fetch-tool prints after storing a fetched reference
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Jun 6, 2007, 11:27 UTC
- Message-ID
- <81b0412b0706060427l1846bde7racabcfea5d15bdb4@mail.gmail.com>
- In-Reply-To
- <7vps495uvs.fsf@assigned-by-dhcp.cox.net>
On 6/6/07, J Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> > Which one was fetched when? /home/user/a or /home/user/a.git? > > I am half tempted to say that this is very close to "doctor, it > confuses me when I have both of them". Imagine the case where > the source were a remote repository _and_ there was no way other > than interacting with it via git protocol. You cannot really > tell (well, you can tell half, by trying both and if a worked > but a.git didn't you can tell that a.git does not exist) nor you > do not really care.
Of course you can! Just print the path to the remote EXACTLY how the user entered it!
Show 7 quoted lines
> > Besides, I just noticed git-clone is broken WRT the .git > > as well: I can clone a "a.git" into "b" (and it ignores -l and -s!), > > but I can't fetch the "a" (aka "origin") being in "b". And of > > course, "origin" in "b" is setup as "/path/a", not "/path/a.git". > > This probably is worth fixing, independent from what the message > says before or after your patch.
And "probably" means: it is broken, but this is ok?