Re: [PATCH] Fix the remote note the fetch-tool prints after storing a fetched reference

"Alex Riesen" <raa.lkml@gmail.com> writes:

I was very tempted to apply this patch, but after re-reading it once more, I decided to drop it.

I do not mind keeping the extra .git/ suffix in the -v output in your example, as the message is just "verbose information":

  $ git fetch -v
    * refs/heads/origin: same as branch 'master' of /home/user/linux
      commit: 5ecd310

But the same output is used by log messages for the merge commits; indeed, the primary purpose of this output is to prepare messages for merge commits. From the beginning we deliberately omitted .git suffix to keep the resulting log message short and sweet. Keeping .git suffix goes against it.

A repository "git://$site/repo.git" can be accessed with "git://$site/repo". Repository owners _can_ confuse their users by having both repo and repo.git, but I honestly do not see a reason to encourage that.

Earlier you mentioned you know of a case where "$URL/repo.git" exists and "$URL/repo" does not, and the current clone fails to set up the target repository after cloning from "$URL/repo" correctly? I admit I haven't reproduced nor debugged it, but if that is the case that needs to be fixed.