Re: [PATCH 2/5] diff --quiet

From: Alex Riesen <raa.lkml@gmail.com>
Date: Mar 15, 2007, 08:22 UTC
Message-ID: <81b0412b0703150122k5a0f1d7u2d2c86e32ff8bbbd@mail.gmail.com>
In-Reply-To: <7vlkhz5rd6.fsf@assigned-by-dhcp.cox.net>

On 3/15/07, Junio C Hamano <junkio@cox.net> wrote:

Show 9 quoted lines

> "Alex Riesen" <raa.lkml@gmail.com> writes:
>
> > Actually, I find it a bit strange to leave the output silent,
> > if --quiet is turned off. For all the user sees, it is still quiet
> > and exit-coded
>
> For that exact reason, for all the user cares, it is better to
> leave the output turned off and result given back with exit
> status.  --quiet is really for scripted use, in other words.

Of course! That's also were the performance matters. Can diff quit early if -Ssomething given?

> I wonder if we should perhaps turn off the PAGER when --exit-code
> or --quiet is given.
>

Second that.Even is just to be on safe side. But again, it is not obvious in case of --exit-code.