Re: [PATCH 2/5] diff --quiet

From: Junio C Hamano <junkio@cox.net>
Date: Mar 15, 2007, 06:47 UTC
Message-ID: <7vy7lz3svl.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7v4pon5mg3.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 12 quoted lines

> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
>> Personally, I think it's more interesting if this can make a difference 
>> for something like
>>
>> 	git log v2.6.12.. -- drivers/ > /dev/null
>>
>> but that would require that we actually understand that we can stop early 
>> if we ever get to REV_TREE_DIFFERENT. I didn't check if you actually did 
>> that optimization.
>
> The code is supposed to be there, but I haven't benched.

Now I have.

In the kernel repository, I ran this with 'master' version and 'next' version. The latter uses the --quick mechanism in try_to_simplify.

$ /usr/bin/time git log -r --raw v2.6.19..master -- drivers/ | wc -l

Three runs on a reasonably quiescent machine (hot cache).

* next (i.e. with the --quick)

5.50user 0.10system 0:05.61elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+15191minor)pagefaults 0swaps

5.50user 0.08system 0:05.58elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+15191minor)pagefaults 0swaps

5.42user 0.07system 0:05.49elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+15192minor)pagefaults 0swaps

* master (without)

7.50user 0.08system 0:07.59elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+15487minor)pagefaults 0swaps

7.70user 0.06system 0:07.77elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+15487minor)pagefaults 0swaps

7.51user 0.08system 0:07.60elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+15487minor)pagefaults 0swaps