git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: change of git-diff-tree and symlinks

From
Junio C Hamano <junkio@cox.net>
Date
May 25, 2005, 19:40 UTC
Message-ID
<7vzmujjdq4.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20050525183546.GA4241@vrfy.org>
>>>>> "KS" == Kay Sievers <kay.sievers@vrfy.org> writes:

KS> Ok, works again. Any reason not to mark it as 'M'? It's easyly to KS> distinguish between a content change and a mode change by looking if KS> the sha has changed.

I'd need some time to think about this in the evening (I'm at work now) but I think Linus did '?' as an interim measure. I suspect 'M' would work just as well without introducing a new class 'T', but on the other hand having them distinct would be easier for people who read diff-raw format, so my knee-jerk reaction is that we should use 'T'. It's the same reasoning to have N, D, and U --- they can be gleaned by looking at mode and sha fields and there is no need to mark them any differently but surely marking them the way we do now is much nicer.

More importantly I need to double check that diffcore stuff including rename/copy are doing the right thing about type changes. If some of them are throwing type-change pair away under certain obscure conditions, then tweaking the part Linus added the '?' is too late to remedy the situation.

Previous: Kay SieversNext: Junio C Hamano
Message 4 of 20 in “change of git-diff-tree and symlinks”
  1. Kay SieversMay 25, 2005
  2. Linus TorvaldsMay 25, 2005
  3. Kay SieversMay 25, 2005
  4. Junio C HamanoMay 25, 2005
  5. Adjust show-files test for dotfiles.Junio C Hamano, May 25, 2005
  6. Fix type-change handling when assigning the status code to filepairs.Junio C Hamano, May 25, 2005
  7. Kay SieversMay 25, 2005
  8. Junio C HamanoMay 25, 2005
  9. Linus TorvaldsMay 25, 2005
  10. Mode only changes from diff.Junio C Hamano, May 25, 2005
  11. Test case portability fix.Junio C Hamano, May 26, 2005
  12. Linus TorvaldsMay 26, 2005
  13. Junio C HamanoMay 26, 2005
  14. Jochen RoemlingMay 29, 2005
  15. Kay SieversMay 29, 2005
  16. Jochen RoemlingMay 29, 2005
  17. Sebastian KuzminskyMay 29, 2005
  18. Sebastian KuzminskyMay 30, 2005
  19. Junio C HamanoMay 29, 2005
  20. Petr BaudisMay 29, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.