Re: change of git-diff-tree and symlinks

From: Junio C Hamano <junkio@cox.net>
Date: May 29, 2005, 18:55 UTC
Message-ID: <7vwtphn9oi.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20050529150656.GA27127@vrfy.org>

>>>>> "KS" == Kay Sievers <kay.sievers@vrfy.org> writes:

>> Also there is a new parameter '-p' that allows the output of a patch 
>> directly instead of creating it with the help of temporary files as you 
>> do it in gitweb.

KS> Sure, gitweb did the diffs before git was able to do that. And it does KS> not really matter who is creating the temp-files, the cgi or the KS> git-binaries. :)

I agree that you are doing the right thing here. In a scripted environment it usually is more sensible not to use '-p' unless generating the diff is the _only_ thing you are doing. '-p' is primarily for people who ends up using the bare plumbing interactively.

KS> If things are stable some day, I may switch that over and maybe even KS> support the nice rename detection.

Sorry for being the primary culprit for the disruption ;-).

You do not have to use '-p' to be able to use rename detection nor any other diffcore stuff. If you are processing "git-diff-tree -r" output right now, you can already process "git-diff-tree -r -B -M -S'foo' -Oorder" output just fine and leave your downstream processing the same as is.