Re: [PATCH] DT_UNKNOWN: do not fully trust existence of DT_UNKNOWN

From: Junio C Hamano <junkio@cox.net>
Date: Jan 20, 2006, 19:10 UTC
Message-ID: <7vzmlqaf5o.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0601200701n76f1d912y4671c6800735cd0d@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 8 quoted lines

> On 1/20/06, Junio C Hamano <junkio@cox.net> wrote:
>> The recent Cygwin defines DT_UNKNOWN although it does not have d_type
>> in struct dirent.  Give an option to tell us not to use d_type on such
>> platforms.  Hopefully this problem will be transient.
>
> You still have to #undef all the DT_ macros if you have a somewhat old Cygwin
> (before Christopher removed the macros).
> -

Ah, you mean something like this?

-- >8 --

diff --git a/cache.h b/cache.h
index 8339931..6f13434 100644
--- a/cache.h
+++ b/cache.h
@@ -13,6 +13,10 @@
 #if defined(DT_UNKNOWN) && !NO_D_TYPE_IN_DIRENT
 #define DTYPE(de)	((de)->d_type)
 #else
+#undef DT_UNKNOWN
+#undef DT_DIR
+#undef DT_REG
+#undef DT_LNK
 #define DT_UNKNOWN	0
 #define DT_DIR		1
 #define DT_REG		2