Re: [PATCH] [BUG] Add a test to check git-prune does not throw away revs hidden by a graft.

Yann Dirson <ydirson@altern.org> writes:

Please don't; I was asleep when I typed it -- sorry.

I was hoping fsck was doing the right thing for a very low level tool -- verify commit objects itself, without relying on the object parser machinery which does funky things like grafts.

Apparently it doesn't -- which is mostly good. You can safely remove commits you wanted to discard by grafting it away like your test did, and you can keep unrelated history you grafted to the back of your real root commit.

For the "clone without propagating grafts" issue, I think we need to have a way to communicate grafts across repositories. As you say, grafts is a local policy issue, but when you start cloning you _are_ sharing that local policy across repositories. Futzing fsck to honor and ignore grafts at the same time sounds like a band-aid to me.