Re: [PATCH] Additional merge-base tests
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jul 4, 2006, 22:42 UTC
- Message-ID
- <7vzmfpf0w2.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0607050021330.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> If that should be not true, you always could rely on topo order. Which > does not seem to solve the problem for you.
The computation of merge-base is about computing topo order cheaply, so that is a recursive definition of the problem, not a solution, I am afraid.
With the generation counter, we know the clean-up phase needs to parse and traverse unparsed parents with the same or higher generation counter than the lowest we have in the result list, which would limit our clean-up traversal. In order to look at the generation number of parent, we would need to parse it, so we would end up parsing one level more than needed at the edge, though.