Re: [PATCH] Avoid C++ comments, use C comments instead
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jul 10, 2006, 07:46 UTC
- Message-ID
- <7vzmfhdhrf.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060710065751.22902.43316.stgit@dv.roinet.com>
Pavel Roskin <proski@gnu.org> writes:
Show 8 quoted lines
> From: Pavel Roskin <proski@gnu.org> > > This doesn't make the code uglier or harder to read, yet it makes the > code more portable. This also simplifies checking for other potential > incompatibilities. "gcc -std=c89 -pedantic" can flag many incompatible > constructs as warnings, but C++ comments will cause it to emit an error. > > Signed-off-by: Pavel Roskin <proski@gnu.org>
The title should probably read "avoid C99 comments", but coming from the previous century, I tend to agree with this.
The struct/array initializer stuff by Shawn makes them harder to read (for structs, it moves initialization to actual code) and more error prone (for arrays, now the initializers need to be carefully kept ordered), but we do not have too many of them in the code, so I do not think it is a not much of a practical problem. It is sad that some people stay behind and we need to cater to them, though.