Re: [PATCH] Avoid C++ comments, use C comments instead

From: Junio C Hamano <junkio@cox.net>
Date: Jul 11, 2006, 00:34 UTC
Message-ID: <7vbqrx6ku8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060711001504.GA10700@spearce.org>

Shawn Pearce <spearce@spearce.org> writes:

Show 7 quoted lines

> Olivier Galibert <galibert@pobox.com> wrote:
>>
>> Maybe git can be perfectly happy with c89.  I don't know.  I know the
>> linux kernel requires c99, mostly for the struct initializers.  My
>> point was that staying at the c89 level has a maintainance cost, and a
>> cost/benefit analysis should be done to decide whether it is a good
>> idea.

I am generally in favor of the effect C99 struct and array initializers have on the readability, but we also need to balance that with the reality. The patch is only about a few structs and one array if I recall correctly isn't it?

What Olivier says is perfectly correct, and after "cost/benefit analysis", I would have to say avoiding some C99 is fine if that makes people's life on some major non-Linux platforms easier.

C99 clean-up is already in the "master", so please do not waste more bandwidth nor time on this issue, but instead spend time elsewhere to make our system better for more people ;-).

Thanks.