Re: [PATCH] Add ability to specify SMTP server port when using git-send-email.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 25, 2007, 23:12 UTC
- Message-ID
- <7vzlza2vcl.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <Pine.LNX.4.64.0709260004090.28395@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 5 quoted lines
> On Tue, 25 Sep 2007, Glenn Rempe wrote:
>
>> +if (($smtp_server =~ /:\d+/) && (defined $smtp_server_port)) {
>
> Not that I want to be a PITA, but this breaks down with IPv6, right?Right. Do we care about symbolic "server.addre.ss:smtp" notation as well, I wonder?