From: Junio C Hamano Date: Tue, 25 Sep 2007 23:12:10 GMT Subject: Re: [PATCH] Add ability to specify SMTP server port when using git-send-email. Message-ID: <7vzlza2vcl.fsf@gitster.siamese.dyndns.org> In-Reply-To: Johannes Schindelin writes: > On Tue, 25 Sep 2007, Glenn Rempe wrote: > >> +if (($smtp_server =~ /:\d+/) && (defined $smtp_server_port)) { > > Not that I want to be a PITA, but this breaks down with IPv6, right? Right. Do we care about symbolic "server.addre.ss:smtp" notation as well, I wonder?