git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Implement git commit as a builtin command.

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 1, 2007, 20:30 UTC
Message-ID
<7vzlxxaeua.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1193944163-22892-1-git-send-email-krh@redhat.com>
Kristian Høgsberg <krh@redhat.com> writes:
Show 15 quoted lines
> Move git-commit.sh to contrib/examples.
>
> Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> ---
>
> Here's the builtin-commit patch again, this time updated to build
> against the in-tree strbuf and option parser.  Now that Pierre has
> done all the work of getting those pieces upstream, I notice that the
> C version ends up 20 lines shorter than the shell script :)
>
> There's a couple of changes to the test suite at the end, which
> removes some EDITOR=: VISUAL=: hard-coding in a few tests and then
> sets the default editor to /bin/true.  This is to address the problem
> that the C version of launch editor doesn't support any kind of shell
> qouting or built-ins.  Should we just use system(3) here?

I do not care much about _how_ it is done, but one of the most often typed command in my .history is

	EDITOR=: git commit
I'd be somewhat unhappy to be forced to retrain my fingers ;-)
Previous: Karl HasselströmNext: Junio C Hamano
Message 6 of 8 in “Implement git commit as a builtin command.”
  1. Implement git commit as a builtin command.Kristian Høgsberg, Nov 1, 2007
  2. Jakub NarebskiNov 1, 2007
  3. Karl HasselströmNov 2, 2007
  4. Junio C HamanoNov 2, 2007
  5. Karl HasselströmNov 2, 2007
  6. Junio C HamanoNov 1, 2007
  7. Junio C HamanoNov 1, 2007
  8. Kristian HøgsbergNov 2, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.