From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 01 Nov 2007 20:30:21 GMT
Subject: Re: [PATCH] Implement git commit as a builtin command.
Message-ID: <7vzlxxaeua.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1193944163-22892-1-git-send-email-krh@redhat.com>

Kristian Høgsberg <krh@redhat.com> writes:

> Move git-commit.sh to contrib/examples.
>
> Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> ---
>
> Here's the builtin-commit patch again, this time updated to build
> against the in-tree strbuf and option parser.  Now that Pierre has
> done all the work of getting those pieces upstream, I notice that the
> C version ends up 20 lines shorter than the shell script :)
>
> There's a couple of changes to the test suite at the end, which
> removes some EDITOR=: VISUAL=: hard-coding in a few tests and then
> sets the default editor to /bin/true.  This is to address the problem
> that the C version of launch editor doesn't support any kind of shell
> qouting or built-ins.  Should we just use system(3) here?

I do not care much about _how_ it is done, but one of the most
often typed command in my .history is

	EDITOR=: git commit

I'd be somewhat unhappy to be forced to retrain my fingers ;-)