Re: [PATCH] Fix parsing numeric color values

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2008, 09:59 UTC
Message-ID: <7vzluez9q9.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080205211821.e4a15194.tihirvon@gmail.com>

Timo Hirvonen <tihirvon@gmail.com> writes:

> Fix bug reported by Chris Larson <clarson@kergoth.com>.  Numeric color
> only worked if it was at end of line.

Signoff?

It is much easier to read if you said that backwards:

        Numeric color only worked if it was at end of line.
        Noticed by Chris Larson <clarson@kergoth.com>.

Show 6 quoted lines

> @@ -17,7 +17,7 @@ static int parse_color(const char *name, int len)
>  			return i - 1;
>  	}
>  	i = strtol(name, &end, 10);
> -	if (*name && !*end && i >= -1 && i <= 255)
> +	if (*name && (!*end || isspace(*end)) && i >= -1 && i <= 255)

Hmph.  Is it the same as (end-name) == len?

Please add a test so that your fix won't be broken by others who might later touch this code.