git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix bug in parse_color that prevented the user from changing the background colors.

From
Chris Larson <clarson@kergoth.com>
Date
Feb 5, 2008, 17:34 UTC
Message-ID
<47A89E2A.9010905@kergoth.com>

The comments in color.c indicate that the syntax for the color options in the git config is [fg [bg]] [attr], however the implementation fails if strtol is unable to convert the string in its entirety into an integer.

Signed-off-by: Chris Larson <clarson@kergoth.com>
---
 color.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/color.c b/color.c
index 7f66c29..62518fa 100644
--- a/color.c
+++ b/color.c
@@ -17,7 +17,7 @@ static int parse_color(const char *name, int len)
             return i - 1;
     }
     i = strtol(name, &end, 10);
-    if (*name && !*end && i >= -1 && i <= 255)
+    if (*name && i >= -1 && i <= 255)
         return i;
     return -2;
 }
-- 
1.5.4.29.g43ce-dirty
Next: Timo Hirvonen
Message 1 of 8 in “Fix bug in parse_color that prevented the user from changing the background colors.”
  1. Fix bug in parse_color that prevented the user from changing the background colors.Chris Larson, Feb 5, 2008
  2. Timo HirvonenFeb 5, 2008
  3. Chris LarsonFeb 5, 2008
  4. Timo HirvonenFeb 5, 2008
  5. Fix parsing numeric color valuesTimo Hirvonen, Feb 5, 2008
  6. Junio C HamanoFeb 6, 2008
  7. Fix parsing numeric color valuesTimo Hirvonen, Feb 6, 2008
  8. Add tests for diff/status color parserTimo Hirvonen, Feb 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.