Re: [PATCH v2 4/5] Add some tests of git-cvsimport's handling of vendor branches

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2009, 16:49 UTC
Message-ID: <7vzlge1kob.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <62960fa97012833859a8f4f8d68a625f8851f8be.1235220105.git.mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

Show 5 quoted lines

> CVS's handling of vendor branches is tricky; add some tests to check
> whether revisions added via "cvs imports" then imported to git via
> "git cvsimport" are reflected correctly on master.
> ...
> One of these tests fail and is therefore marked "test_expect_failure".

In addition to the one marked with expect-failure, 2, 4, 6, 7, 8 and 9 seems to fail for me as well.

    $ sh t9601-cvsimport-vendor-branch.sh -i -v
    Initialized empty Git repository in /git/git.git/t/trash directory.t9601-cvsimport-vendor-branch/.git/
    * expecting success:

            git cvsimport -C module-git module

    Initialized empty Git repository in /git/git.git/t/trash directory.t9601-cvsimport-vendor-branch/module-git/.git/
    Skipping #CVSPS_NO_BRANCH
    *   ok 1: import a module with a vendor branch

    * expecting success: test_cvs_co master
    ./test-lib.sh: line 256: test_cvs_co: command not found
    * FAIL 2: check HEAD out of cvs repository
            test_cvs_co master

The reported line is where the broken test is actually "eval"ed; the second test tries to use the undefined test_cvs_co function.