git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/4] Add more tests of cvsimport

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Feb 21, 2009, 13:04 UTC
Message-ID
<1235221480-31473-1-git-send-email-mhagger@alum.mit.edu>
Thanks for all the feedback.  I think I have incorporated it all:
- Renamed the library from t/t96xx/cvs-lib.sh to t/lib-cvs.sh.
- Added t/t9601/cvsroot/.gitattributes to avoid whitespace warnings.
- Fixed the "cvs co" command for when checking out a branch/tag.
- Implemented a recursive diff in test_cmp_branch_tree rather than
  relying on GNU diff features.  It is only a dozen lines of code, but
  please review this carefully as I'm not such a shell jockey.
  I tried using "git diff" but it didn't seem to work for this
  purpose, even if I deleted the CVS directories manually to avoid the
  need for "-x" functionality:
  - If I used --no-index, it insisted on showing differences within
    the .git directory.
  - It didn't seem to find any differences (even when there were some)
    when I didn't use --no-index.
  - I couldn't see any documentation that the return value is nonzero
    iff differences are found.  In my tests the return value was
    always zero.
  The library can always be changed later to use "git diff", but I
  don't see this as urgent.  It would also have the disadvantage of
  making "git cvsimport" tests fail if there are bugs in "git diff".

I also added another test script, t9602, in the (new) 5th patch in the series. It tests "git cvsimport"'s handling of branches and tags. Only 5/11 of the tests in this script pass.

Cheers, Michael

Next: Michael Haggerty
Message 1 of 14 in “Add more tests of cvsimport”
  1. 0/4 Add more tests of cvsimportMichael Haggerty, Feb 21, 2009
  2. 1/5 Start a library for cvsimport-related testsMichael Haggerty, Feb 21, 2009
  3. 2/5 Use CVS's -f option if available (ignore user's ~/.cvsrc file)Michael Haggerty, Feb 21, 2009
  4. 3/5 Test contents of entire cvsimported "master" tree contentsMichael Haggerty, Feb 21, 2009
  5. 4/5 Add some tests of git-cvsimport's handling of vendor branchesMichael Haggerty, Feb 21, 2009
  6. 5/5 Add a test of "git cvsimport"'s handling of tags and branchesMichael Haggerty, Feb 21, 2009
  7. Junio C HamanoFeb 22, 2009
  8. 0/5 Add more tests of cvsimportMichael Haggerty, Feb 23, 2009
  9. 1/5 Start a library for cvsimport-related testsMichael Haggerty, Feb 23, 2009
  10. 2/5 Use CVS's -f option if available (ignore user's ~/.cvsrc file)Michael Haggerty, Feb 23, 2009
  11. 3/5 Test contents of entire cvsimported "master" tree contentsMichael Haggerty, Feb 23, 2009
  12. 4/5 Add some tests of git-cvsimport's handling of vendor branchesMichael Haggerty, Feb 23, 2009
  13. 5/5 Add a test of "git cvsimport"'s handling of tags and branchesMichael Haggerty, Feb 23, 2009
  14. Junio C HamanoFeb 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.