Re: [PATCH] Display author and committer after "git commit"

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 11, 2010, 07:28 UTC
Message-ID: <7vzl4lw160.fsf@alter.siamese.dyndns.org>
In-Reply-To: <xuu2fx6d9rzb.fsf_-_@nowhere.com>

Adam Megacz <adam@megacz.com> writes:

> Display author (name, email, date) and committer (name, email, date)
> after creating a new commit to ensure that the user is alerted in the
> event that they are set in an undesirable manner.

Too much clutter for too little gain, except for a very first few commits in the repository.

Why isn't the "# Author:" and "# Committer:" information you see along with "git status" output in the editor "git commit" gives you sufficient if it is to avoid unconfigured/misconfigured names and e-mail addresses?

Show 12 quoted lines

> This patch is not necessarily meant for inclusion verbatim;
> ...
> diff --git a/pretty.c b/pretty.c
> index 8f5bd1a..2458509 100644
> --- a/pretty.c
> +++ b/pretty.c
> @@ -1028,16 +1028,26 @@ void pretty_print_commit(enum cmit_fmt fmt, const struct commit *commit,
>  	int need_8bit_cte = context->need_8bit_cte;
>  
>  	if (fmt == CMIT_FMT_USERFORMAT) {
> -		format_commit_message(commit, user_format, sb, context);
> +                format_commit_message(commit, user_format, sb, context);

Of course it isn't, with a change like this ;-)

Indentation damages aside, there is a lot more serious issue with this. You added this cruft *unconditionally* to show_log(). Doesn't it mean that you made format-patch *unusable*? Try:

	git am your_patch.mbox
        make install
	for i in 1 2 3 4 5
        do
                git format-patch -1 --stdout >patch.mbox
                git reset --hard HEAD^
                git am patch.mbox
	done        
	git show -s

and weep.

Have you checked --pretty=fuller, by the way?