Re: [PATCH v2 3/3] commit: show interesting ident information in summary

From: Jeff King <peff@peff.net>
Date: Jan 13, 2010, 18:45 UTC
Message-ID: <20100113184510.GA22849@coredump.intra.peff.net>
In-Reply-To: <1DDB570B-350A-40A0-B6E4-ADBDF4BE6BD2@wincent.com>

On Wed, Jan 13, 2010 at 07:39:47PM +0100, Wincent Colaiuta wrote:

Show 19 quoted lines

> > Your name and email address were configured automatically based
> > on your username and hostname. Please check that they are accurate.
> > You can suppress this message by setting them explicitly:
> >
> >     git config --global user.name Your Name
> >     git config --global user.email you@example.com
> >
> > If the identity used for this commit is wrong, you can fix it with:
> >
> >     git commit --amend --author='Your Name <you@example.com>'
> >
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> I'll never see this message myself, but I think you could (and
> perhaps should) replace almost all of that with:
> 
>   Your name and email address were configured automatically.
>   See "git config help" for information on setting them explicitly
>   or "git commit help" if you wish to amend this commit.

I don't have a huge problem with your wording, except that it needs s/(\w+) help/help \1/.

Mainly I was trying to hand-hold because not having this information set up means it may be your first commit, and you are probably a bit clueless (the exceptions are people who have been using git, but are seeing this new behavior in their new version, and people who have git configured on another machine but are using _this_ machine for the first time).

As far as reducing verbosity goes, I don't think there is much point. Both of ours are huge and annoying enough to nag you into setting up your config, so the user is only likely to see it a few times.

> But like I said, seeing as I won't see the message its verbosity won't
> directly affect me.

I am also in this boat. :)

-Peff