git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff --follow: do call diffcore_std() as necessary

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 13, 2010, 22:46 UTC
Message-ID
<7vzkwqi10w.fsf@alter.siamese.dyndns.org>
In-Reply-To
<AANLkTin-qPe-meW_kV5vtC0BT8QS-sZ90BrckRAbjk9X@mail.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 8 quoted lines
> On Fri, Aug 13, 2010 at 19:46, Junio C Hamano <gitster@pobox.com> wrote:
>
>> This hopefully fixes the breakage.
>
> Hopefully. It'd also be nice if we had a regression test for this, but
> I don't know how hard that would be to arrange. If it's hard to
> reproduce we might get away with a filter-branch + subdir filter from
> the idea repository.

As I wrote, the test added by 0cdca13 breaks with just a reversion of 1da6175 but with this patch it passes. I didn't run any other test, though ;-).

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 8 of 16 in “BUG: git log: fatal: internal error in diff-resolve-rename-copy”
  1. Constantine PlotnikovAug 13, 2010
  2. Ævar Arnfjörð BjarmasonAug 13, 2010
  3. Junio C HamanoAug 13, 2010
  4. Linus TorvaldsAug 13, 2010
  5. Junio C HamanoAug 13, 2010
  6. diff --follow: do call diffcore_std() as necessaryJunio C Hamano, Aug 13, 2010
  7. Ævar Arnfjörð BjarmasonAug 13, 2010
  8. Junio C HamanoAug 13, 2010
  9. log: test for regression introduced in v1.7.2-rc0~103^2~2Ævar Arnfjörð Bjarmason, Aug 14, 2010
  10. Ævar Arnfjörð BjarmasonAug 14, 2010
  11. Junio C HamanoAug 15, 2010
  12. Ævar Arnfjörð BjarmasonAug 15, 2010
  13. Junio C HamanoAug 16, 2010
  14. Ævar Arnfjörð BjarmasonAug 16, 2010
  15. log: test for regression introduced in v1.7.2-rc0~103^2~2Ævar Arnfjörð Bjarmason, Aug 15, 2010
  16. Constantine PlotnikovAug 17, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.