Re: [PATCH] log: test for regression introduced in v1.7.2-rc0~103^2~2

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 15, 2010, 09:08 UTC
Message-ID: <7v39uggs5h.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTi=Na_K=9oXM7iyeKodWXyXuSy-0UL792igTEjEe@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 5 quoted lines

> On Sat, Aug 14, 2010 at 01:10, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>> Add a regression test for the git log -M --follow --name-only bug
>> introduced in v1.7.2-rc0~103^2~2
>
> AKA "we didn't have any tests for log's --name-only *at all*".

But this is not related to --name-only at all; anything that is "diff" related, e.g. -p, --stat, --name-status, will share the same issue.

Show 9 quoted lines

> diff --git a/t/t4202-log.sh b/t/t4202-log.sh
> index 95ac3f8..ff624f4 100755
> --- a/t/t4202-log.sh
> +++ b/t/t4202-log.sh
> @@ -441,5 +441,14 @@ test_expect_success 'log.decorate configuration' '
>  
>  '
>  
> +test_expect_success 'Regression test for v1.7.2-rc0~103^2~2' '

This is uninformative and ugly at the same time.

 - Can't we describe the nature of the situation where the old bug
   triggers concisely?  Perhaps 'show added path under "--follow -M"?'

 - All others begin with lowercase.

> +	# Needs an unrelated root commit
> +	test_commit README &&

This is not a "root" commit, is it?

> +	>Foo.bar &&
> +	git add Foo.bar &&
> +	git commit --allow-empty-message </dev/null &&

Does emptiness of the message matter?

> +	git log -M --follow --name-only Foo.bar
> +'
> +
>  test_done