Re: XDL_FAST_HASH breaks git on OS X 10.7.3

From: Junio C Hamano <gitster@pobox.com>
Date: May 1, 2012, 06:17 UTC
Message-ID: <7vzk9sbf2l.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAJDDKr778t=CufdtitbrhB-vJ3F=xSpSJ_G8e-VK8qCy8Fcfmg@mail.gmail.com>

David Aguilar <davvid@gmail.com> writes:

Show 5 quoted lines

>> +       if (sizeof(long) == 8) {
>
> Isn't the whole point of this code to be fast?
>
> This should be a compile-time check... conditionals hurt perf.

Depends on how good your compiler is, no? The above if () selects based on a constant expression, so on 64-bit archs with a good compiler, there won't be a jump instruction nor a single opcode for the else clause.